-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix endian-dependence of test introduced in gh-16380 #16391
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
cc @pllim: sorry for introducing the bug, but at least now you know the cron failures will be temporary! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have a slight preference for specifying an endianness where data is initialized but not a big deal. This also works !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hmm but "exotic" archs still have failures. Are they related? |
Good point, I missed that. Looks like a completely separate problem to me, more likely linked to #16346, but I'm confused why we're only seeing it here. |
@pllim can we manually trigger weekly cron on main now just to check that the problem is reproducible outside this branch ? |
Yes. But might take a few hours: https://github.com/astropy/astropy/actions/runs/8970422440 |
For the jobs that completed, I do see the failures on |
Now it's there ! |
Just to be sure, the dask failures in pre-deps are also unrelated, right? https://github.com/astropy/astropy/actions/runs/8962574869/job/24611632967?pr=16391 |
Yeah, it's not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving by proxy. Thanks!
Yes, dask failures were solved in #16384 |
Yes, it is green now. Thanks! https://github.com/astropy/astropy/actions/runs/8974310244 |
Thanks @pllim and @neutrinoceros! |
Description
This pull request is to address a test error on big-endian systems introduced in #16380 - e.g., see
https://github.com/astropy/astropy/actions/runs/8960434431/job/24606929816
Hence, the extra CI.