Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix endian-dependence of test introduced in gh-16380 #16391

Merged
merged 1 commit into from
May 6, 2024

Conversation

mhvk
Copy link
Contributor

@mhvk mhvk commented May 6, 2024

Description

This pull request is to address a test error on big-endian systems introduced in #16380 - e.g., see
https://github.com/astropy/astropy/actions/runs/8960434431/job/24606929816

Hence, the extra CI.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@mhvk mhvk added testing utils no-changelog-entry-needed Extra CI Run cron CI as part of PR backport-v6.1.x on-merge: backport to v6.1.x labels May 6, 2024
@mhvk mhvk added this to the v6.1.1 milestone May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk
Copy link
Contributor Author

mhvk commented May 6, 2024

cc @pllim: sorry for introducing the bug, but at least now you know the cron failures will be temporary!

Copy link
Contributor

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have a slight preference for specifying an endianness where data is initialized but not a big deal. This also works !

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
Copy link
Member

pllim commented May 6, 2024

Hmm but "exotic" archs still have failures. Are they related?

@neutrinoceros
Copy link
Contributor

Good point, I missed that. Looks like a completely separate problem to me, more likely linked to #16346, but I'm confused why we're only seeing it here.

@neutrinoceros
Copy link
Contributor

@pllim can we manually trigger weekly cron on main now just to check that the problem is reproducible outside this branch ?

@pllim
Copy link
Member

pllim commented May 6, 2024

Yes. But might take a few hours: https://github.com/astropy/astropy/actions/runs/8970422440

@pllim
Copy link
Member

pllim commented May 6, 2024

For the jobs that completed, I do see the failures on main too. Hmm...

@neutrinoceros
Copy link
Contributor

Now it's there !
I think we can go ahead with this one, and I can dig into remaining failures tomorrow !

@pllim
Copy link
Member

pllim commented May 6, 2024

Just to be sure, the dask failures in pre-deps are also unrelated, right?

https://github.com/astropy/astropy/actions/runs/8962574869/job/24611632967?pr=16391

@pllim
Copy link
Member

pllim commented May 6, 2024

Yeah, it's not.

Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving by proxy. Thanks!

@pllim pllim merged commit 8c425b8 into astropy:main May 6, 2024
30 of 37 checks passed
@pllim pllim added the Affects-dev PRs and issues that do not impact an existing Astropy release label May 6, 2024
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 6, 2024
@neutrinoceros
Copy link
Contributor

Yes, dask failures were solved in #16384

@pllim
Copy link
Member

pllim commented May 6, 2024

Yes, it is green now. Thanks! https://github.com/astropy/astropy/actions/runs/8974310244

@mhvk
Copy link
Contributor Author

mhvk commented May 6, 2024

Thanks @pllim and @neutrinoceros!

@mhvk mhvk deleted the utils-masked-pr-fix branch May 6, 2024 23:05
pllim added a commit that referenced this pull request May 7, 2024
…391-on-v6.1.x

Backport PR #16391 on branch v6.1.x (Fix endian-dependence of test introduced in gh-16380)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects-dev PRs and issues that do not impact an existing Astropy release backport-v6.1.x on-merge: backport to v6.1.x Extra CI Run cron CI as part of PR no-changelog-entry-needed testing utils.masked utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants