Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #16391 on branch v6.1.x (Fix endian-dependence of test introduced in gh-16380) #16397

Merged

Conversation

meeseeksmachine
Copy link

Backport PR #16391: Fix endian-dependence of test introduced in gh-16380

@lumberbot-app lumberbot-app bot added this to the v6.1.1 milestone May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
Copy link
Member

pllim commented May 6, 2024

Weird failures... gonna close/reopen and see.

@pllim pllim closed this May 6, 2024
@pllim pllim reopened this May 6, 2024
@pllim pllim mentioned this pull request May 6, 2024
1 task
@pllim
Copy link
Member

pllim commented May 7, 2024

aarch64 timed out but the others passed, so probably good enough for a backport PR. 🤷‍♀️

@pllim pllim merged commit 29dab0b into astropy:v6.1.x May 7, 2024
41 of 56 checks passed
@neutrinoceros
Copy link
Contributor

These timeouts have been consistent for a little while now, so I don't think it's related (but I have no idea what's causing them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants