Fix x, y order with numpy.mgrid usage #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great - thanks for fixing this! |
|
Ready to merge? |
|
I think this needs an entry in the changelog, especially if it has the potential to change modeling results. Also, this will need a new 0.3.2 section for the changelog (since we have 'frozen' 0.3.1). |
|
Does this really need a change log entry? |
astrofrog
added a commit
that referenced
this pull request
Feb 26, 2014
Fix x, y order with numpy.mgrid usage
astrofrog
added a commit
that referenced
this pull request
Mar 27, 2014
Fix x, y order with numpy.mgrid usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2038 with @larrybradley and illustrated here, the correct way to use np.mgrid to create coordinate arrays
xandyisy, x = np.mgrid[0:100, 0:200].For np.meshgrid it is
X, Y = np.meshgrid(x, y)for the defaultindexing='xy'order.This PR fixes a few cases in the modeling tests and docs where the wrong order was used.