Fix bugs with evaluating models that accept no inputs. #3772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embray
force-pushed
the
modeling/fix-inputless-model
branch
from
95c95e9
to
8e1af77
Compare
|
I now get a problem with and output is an array. I wonder if these are related. |
… model sets) with array-like output.
|
Ah, I thought I had that case covered, but it turns out I didn't. I've extended the test to check more possibilities, and fixed the issue. |
|
that did it! thanks @embray |
|
it's quite a bit slower than my solution - I'll checkout what is going on. |
|
Could you quantify that? What exactly is slower and by how much? There's nothing about this change that is at all computationally expensive unless you have some enormous number of outputs. |
|
@embray nevermind, must have been something on my side! Anyways, thanks a lot this is great and from my side definitely ready to be merged. |
embray
added a commit
that referenced
this pull request
May 14, 2015
Fix bugs with evaluating models that accept no inputs.
embray
added a commit
that referenced
this pull request
May 28, 2015
Fix bugs with evaluating models that accept no inputs.
dhomeier
pushed a commit
to dhomeier/astropy
that referenced
this pull request
Aug 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue pointed out by @wkerzendorf, where models with zero inputs did not work. Incidentally the fix is almost exactly the one he put in temporarily. Just fixed it in another case as well.