Inputs to render function are converted to float #4681

[aniketk21]

@eteq @patti out and coords are converted to float. Please suggest any changes. #4681

[aniketk21]

@eteq @patti Please review.

[bmorris3]

Looks good. I'm going to wait on a response from @eteq and @patti to double check that the coords array should be forced to an array.

[patti]

@aniketk21 Looks good to me, but the if statements are redundant with those below and can be merged. I'm effectively off the grid for the next month, so I'm going to be slow to reply. If @eteq is happy, I'm happy.

[aniketk21]

@patti I'll merge them.

[aniketk21]

Should I update the docs and add a changelog?

[pllim]

Maybe a change log.

[aniketk21]

@pllim Under which version should I add a change log?

[pllim]

That is a question for your mentor. Is it @eteq ?

[aniketk21]

@eteq Under which version should I add a change log?

[eteq]

@aniketk21 - Lets call it 1.2, as I said in #4681. if it's a change in behavior it normally has to go in the next "major" version. So it should be mentioned both in the modeling section and as an "API change" (it's worth noting that it's a change to reflect the fact that this was the intent, but it was never clearly stated as far as I know in the docs, so it's not a bug per se but rather an implementation oversight).

[aniketk21]

I'm not sure why the build failed. Maybe it happened because I did git fetch astropy in the render-4681 branch by mistake. What should I do now?

[bsipocz]

@aniketk21 - There are conflicts, thus the ci can't start, you need to rebase your branch on top of the latest master.

[pllim]

Remove this duplicate change log entry.

[aniketk21]

Okay, thanks!

[pllim]

Also, would be nice to squash the commits into one before merge, given that there are only effectively 2 lines of new codes, which do not justify 4 different commits.

git rebase -i HEAD~4

[aniketk21]

@pllim I've squashed all commits into one.

[pllim]

Thanks, @aniketk21 !

Looks good to me as well. So, the final question is, "Are you happy, @eteq ?"

[astrofrog]

@aniketk21 - could you rebase again on the latest master version?

[aniketk21]

@astrofrog rebased on the latest master.

[eteq]

I am happy ;) Merging!