Read colnames of LaTeX files with units as written by Astropy #5237
Conversation
| @@ -321,6 +321,16 @@ class AASTexHeaderSplitter(LatexSplitter): | |||
| This splitter expects the following LaTeX code **in a single line**: | |||
|
|
|||
| \tablehead{\colhead{col1} & ... & \colhead{coln}} | |||
|
|
|||
| If the \tablehead defines multiple output lines separated by \\ | |||
There was a problem hiding this comment.
I think that everything that's code (even LaTeX code) should be enclosed like this:
If the `\tablehead`
so that sphinx renders it nicely.
|
I think you mentioned that you had looked at the tests for round-tripping. Can you add that test to this PR? It's always good to test a new feature or a bug fix when it's implemented. Also, can you add an entry under "bug fixes" in the CHANGES.rst file? |
|
Hi humans 👋 - this pull request hasn't had any new commits for approximately 1 year, 1 month. I plan to close this in a month if the pull request doesn't have any new commits by then. In lieu of a stalled pull request, please close this and open an issue instead to revisit in the future. Maintainers may also choose to add If you believe I commented on this issue incorrectly, please report this here. |
|
⏰ Time's up! ⏰ I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks! If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here. |
This is a partial solution to reading of LaTeX tables written by astropy.io.ascii.aastex that had units included. This solution only reads out the colnames, it does not read the units.
It does this by spliting off first r'' delimited section of tablehead to be AASTex colnames
It can read cases where the
\tableheadis all one line (as is that produced by units-enabled astropy.io.ascii.aastex), but fails on cases where the\tableheadcommand is split over several lines in the table file (which was also previously true for the Latex and AASTeX readers).