Fix AstropyDeprecationWarning for deprecated longitude and latitude #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
Affects-dev
|
@pllim - Thanks. 👍 |
|
@eteq - it seemed we missed some of the tests that used |
|
Update: Travis passed on my fork. |
|
I don't think this is controversial, so I am going to merge now so I can continue to debug other warnings for #6140. |
bsipocz
pushed a commit
that referenced
this pull request
Jun 23, 2017
Fix AstropyDeprecationWarning for deprecated longitude and latitude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
AstropyDeprecationWarningfor deprecated longitude and latitude in coordinates, introduced in #6237.These were not caught on Travis because Astropy's
conftest.pydoes not turnAstropyDeprecationWarninginto exceptions.Address part of #6251
NOTE: I cancelled Travis here due to queue. Actual Travis result at my fork -- https://travis-ci.org/pllim/astropy/builds/245509661