New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workaround for einsum issues in norm() #7187
Conversation
Hi there @astrofrog 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
6f0d93c
to
a5f4b94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted, for python3 this is good too, as it avoids a large slowdown.
This actually passed on AppVeyor but there is some kind of issue with reporting the results back. |
Add workaround for einsum issues in norm()
Add workaround for einsum issues in norm()
Add workaround for einsum issues in norm()
Add workaround for einsum issues in norm()
This doesn't actually cause issues in master at the moment but does cause issues in v2.0.x. @mhvk suggested including the fix in master anyway just to be safe, and we can backport this to v2.0.x.