Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable xfail_strict pytest config by default #7194

Closed

Conversation

giang-nghg
Copy link
Contributor

@giang-nghg giang-nghg commented Feb 13, 2018

Fixes #7065

@astropy-bot
Copy link

astropy-bot bot commented Feb 13, 2018

Hi there @giang-nghg 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

If there are any issues with this message, please report them here.

@pllim
Copy link
Member

pllim commented Feb 13, 2018

Thank you for the PR!

These are reported as XPASS (in astropy/coordinates/tests/test_sky_coord_velocities.py) and will need to be addressed by coordinates experts:

=================================== FAILURES ===================================
__________________________ test_transforms_diff[sc1] ___________________________
[XPASS(strict)] 
__________________________ test_transforms_diff[sc3] ___________________________
[XPASS(strict)] 

@pllim
Copy link
Member

pllim commented Mar 8, 2018

I have incorporated your commit into #7267 . FYI. Once (if) that is merged, this will be closed. However, you will still be credited because I did a cherry pick. Thank you again for your contribution!

@mhvk mhvk closed this in #7267 Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants