Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_models only to initialize modelsets #7271

Closed
wants to merge 1 commit into from

Conversation

vermashresth
Copy link
Contributor

Removed the option to initalize a model set without providing n_models as parameter.
#7223

@astropy-bot
Copy link

astropy-bot bot commented Mar 9, 2018

Hi there @vermashresth 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issue with this pull request:

  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix this? Thanks!

If there are any issues with this message, please report them here.

@bsipocz bsipocz requested a review from nden March 9, 2018 12:30
@bsipocz bsipocz added this to the v3.1 milestone Mar 9, 2018
@nden
Copy link
Contributor

nden commented Mar 10, 2018

@vermashresth Thanks for investigating and implementing this. There are various other issues with model sets. I want to summarize them and reach an agreement of what needs to be supported and how. So I suggest to keep this open until there's a decision as it may be part of the bigger refactoring.
I am still in favor of limiting the many ways one can create and work with model sets.

@astropy-bot
Copy link

astropy-bot bot commented Aug 16, 2018

Hi humans 👋 - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock. You may also consider sending a reminder e-mail about it to the astropy-dev mailing list.

If you believe I commented on this pull request incorrectly, please report this here.

@astropy-bot
Copy link

astropy-bot bot commented Sep 20, 2018

⏰ Time's up! ⏰

I'm going to close this pull request as per my previous message. If you think what is being added/fixed here is still important, please remember to open an issue to keep track of it. Thanks!

If this is the first time I am commenting on this issue, or if you believe I closed this issue incorrectly, please report this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants