Fix mismatched integer sizes in compressionmodule.c on 32-bit #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On 32-bit plaftorms, including Travis, we get this compiler warning.
Particular when passing the list of dimensions, this could result in the very wrong array size being created.
This uses
npy_intp
instead oflong
so the array sizes match on 32-bit and 64-bit.This may or may not be the cause of the segfaults on Travis, but either way we should probably fix this.