-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo in HighLevelWCSWrapper for axis_correlation_matrix #9554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️
the tests need to be updated, too. |
I pushed a commit directly to the branch. FYI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and that is the correct fix for the test
Edit: this might actually affect released versions, so if so it will need a changelog entry. I can try and check later unless someone beats me to it.
|
I think it does affect release... I see this in v3.2.x and v3.1.x branches but not those before: astropy/astropy/wcs/wcsapi/high_level_wcs_wrapper.py Lines 66 to 71 in b70ce87
|
Change log added. And just for completeness, this fixes a bug introduced in #7326 that was milestoned to v3.1. |
Good catch, @sfgraves . Thank you! |
Thanks @sfgraves! |
This fixes a small typo in the HighLevelWCSWrapper so that the axis_correlation_matrix from the low level object is correctly exposed.
Description
This pull request is to address ...
Fixes #