Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in HighLevelWCSWrapper for axis_correlation_matrix #9554

Merged
merged 3 commits into from
Nov 7, 2019

Conversation

sfgraves
Copy link
Contributor

@sfgraves sfgraves commented Nov 7, 2019

This fixes a small typo in the HighLevelWCSWrapper so that the axis_correlation_matrix from the low level object is correctly exposed.

Description

This pull request is to address ...

Fixes #

Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@bsipocz bsipocz added this to the v4.0 milestone Nov 7, 2019
@bsipocz bsipocz added the Affects-dev PRs and issues that do not impact an existing Astropy release label Nov 7, 2019
@bsipocz
Copy link
Member

bsipocz commented Nov 7, 2019

the tests need to be updated, too.

@bsipocz bsipocz requested a review from Cadair November 7, 2019 15:52
@pllim
Copy link
Member

pllim commented Nov 7, 2019

I pushed a commit directly to the branch. FYI.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and that is the correct fix for the test

Edit: this might actually affect released versions, so if so it will need a changelog entry. I can try and check later unless someone beats me to it.

@pllim
Copy link
Member

pllim commented Nov 7, 2019

mpldev failure is unrelated.

@pllim
Copy link
Member

pllim commented Nov 7, 2019

I think it does affect release... I see this in v3.2.x and v3.1.x branches but not those before:

@property
def axis_correlation_matrix(self):
"""
See `~astropy.wcs.wcsapi.BaseLowLevelWCS.axis_correlation_matrix`
"""
return self.low_level_wcs.pixel_bounds

@pllim pllim added Affects-release and removed Affects-dev PRs and issues that do not impact an existing Astropy release labels Nov 7, 2019
@pllim
Copy link
Member

pllim commented Nov 7, 2019

Change log added. And just for completeness, this fixes a bug introduced in #7326 that was milestoned to v3.1.

@pllim pllim added the 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Nov 7, 2019
@pllim
Copy link
Member

pllim commented Nov 7, 2019

Good catch, @sfgraves . Thank you!

@bsipocz bsipocz merged commit 22fe622 into astropy:master Nov 7, 2019
@bsipocz
Copy link
Member

bsipocz commented Nov 7, 2019

Thanks @sfgraves!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wcs.wcsapi wcs 💤 merge-when-ci-passes Do not use: We have auto-merge option now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants