Set units and descriptions in Table init #9671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
reviewed
Nov 25, 2019
taldcroft
force-pushed
the
table-unit-init
branch
from
eafb0b6
to
4e0eea0
Compare
|
I added kwargs to |
mhvk
reviewed
Nov 25, 2019
taldcroft
changed the title
taldcroft
force-pushed
the
table-unit-init
branch
from
16ecf28
to
ab311f9
Compare
mhvk
approved these changes
Nov 26, 2019
| @@ -33,6 +33,10 @@ class TableRead(registry.UnifiedReadWrite): | |||
| first argument is typically the input filename. | |||
| format : str | |||
| File format specifier. | |||
| units : list, dict, optional | |||
| List or dict of units to apply to columns | |||
There was a problem hiding this comment.
Missing the periods at the end here too....
| if not values: | ||
| return | ||
|
|
||
| if isinstance(values, Row): |
There was a problem hiding this comment.
For future, perhaps we should have Rows.items() so there isn't a need to special-case it.
| # For a Row object transform to an equivalent dict. | ||
| values = {name: values[name] for name in values.colnames} | ||
|
|
||
| if not isinstance(values, dict): |
There was a problem hiding this comment.
Might even register Row as collections.abc.Mapping, and then do the instance on that (I'm a bit puzzled it is considered a Sequence now, since one cannot index with the column number anyway; similarly, Row.__iter__ is weird.
But really out of scope here! See #9687
|
@adrn , now you can do it with dev astropy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows explicitly setting both the
unitsanddescriptionsof specified table columns from theTable.__init__()andTable.read()methods.Closes #9639
It provides some mitigation for #9665 (read units row from ASCII table) by making it easier to do that: