Add TableList class to astroquery.utils #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return info_str | ||
|
|
||
| def list_contents(self): |
There was a problem hiding this comment.
As I mentioned in #125, I think this should be print_tables
|
@jdnc - it looks like this may need rebasing? |
|
@astrofrog - I have rebased this basically following your instructions at astropy/astropy#1203 (comment) and using meld. The branch couldn't be merged automatically - but I missed this while making the PR. Is it all right now? I'll also rename the |
|
All right so did the rebase again and pushed ( I missed including the |
|
@jdnc - this looks good, is it ready to be merged? |
|
Yes, no more pending commits on this. |
astrofrog
added a commit
that referenced
this pull request
Jul 17, 2013
Add TableList class to astroquery.utils
jdnc
pushed a commit
to jdnc/astroquery
that referenced
this pull request
Jul 30, 2013
Add TableList class to astroquery.utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
TableListclass toastroquery.utils.commonswhich is an extension of anOrderedDict. It should be as anOrderedDictcontainer forastropy.table.Tableobjects - having table names as keys and the correspondingastropy.table.Tableobject as the value.