Refactor splatalogue #151
Merged
Refactor splatalogue #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failures are because: @astrofrog, do you know what I've done wrong in |
splatalogue refactor (for real)
(since they follow a trivial common boilerplate)
methods and auto-generate the non-async versions
wrapper because "The nested function looks up variables from the parent scope when executed, not when defined." See http://stackoverflow.com/questions/12423614/local-variables-in-python-nested-functions
Python packaging is confusing.
didn't change anything.
|
Made a blog post on some of my favorite (most common) queries with splatalogue, the whole reason I made this interface in the first place (see agpy/query_splatalogue...): http://keflavich.github.io/blog/my-favorite-splatalogue-queries.html |
Conflicts: astroquery/utils/process_asyncs.py astroquery/utils/tests/test_utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rewrite of splatalogue, based more off of http://agpy.googlecode.com/svn/trunk/agpy/query_splatalogue.py than the
mechanizeversion.It provides an interface that resembles the splatalogue web interface, NOT a fully functional VO-enabled SLAP interface. The latter is possible, but the documentation seems to be presently unavailable, so we cannot support that interface.
This doesn't fully conform to the astroquery API, but it goes most of the way.
There are still problems with docstrings not being inherited properly.
This depends on PR #149