-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor splatalogue #151
Refactor splatalogue #151
Conversation
Build failures are because:
@astrofrog, do you know what I've done wrong in |
splatalogue refactor (for real)
(since they follow a trivial common boilerplate)
methods and auto-generate the non-async versions
wrapper because "The nested function looks up variables from the parent scope when executed, not when defined." See http://stackoverflow.com/questions/12423614/local-variables-in-python-nested-functions
Python packaging is confusing.
didn't change anything.
Made a blog post on some of my favorite (most common) queries with splatalogue, the whole reason I made this interface in the first place (see agpy/query_splatalogue...): http://keflavich.github.io/blog/my-favorite-splatalogue-queries.html |
Conflicts: astroquery/utils/process_asyncs.py astroquery/utils/tests/test_utils.py
This is a complete rewrite of splatalogue, based more off of http://agpy.googlecode.com/svn/trunk/agpy/query_splatalogue.py than the
mechanize
version.It provides an interface that resembles the splatalogue web interface, NOT a fully functional VO-enabled SLAP interface. The latter is possible, but the documentation seems to be presently unavailable, so we cannot support that interface.
This doesn't fully conform to the astroquery API, but it goes most of the way.
There are still problems with docstrings not being inherited properly.
This depends on PR #149