Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Cleanup of old unused code and configs #2231

Merged
merged 3 commits into from
Nov 27, 2021

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Nov 26, 2021

Some uncontroversial code cleanup.

This also removes unused config files, and the long-unused frontpage maker. @keflavich - I'll wait for your OK on this latter point before merging this.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #2231 (f12ddd0) into main (0833f63) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2231   +/-   ##
=======================================
  Coverage   61.90%   61.91%           
=======================================
  Files         129      129           
  Lines       16310    16305    -5     
=======================================
- Hits        10097    10095    -2     
+ Misses       6213     6210    -3     
Impacted Files Coverage Δ
astroquery/lamda/core.py 71.72% <0.00%> (+0.74%) ⬆️
astroquery/splatalogue/core.py 87.01% <ø> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0833f63...f12ddd0. Read the comment docs.

Copy link
Contributor

@keflavich keflavich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is pip-requirements just handled by setup.cfg now?

rtd-environment is docs/rtd-something?

I'm just trying to catch up on ecosystem changes. The changes you propose are OK by me.

@bsipocz
Copy link
Member Author

bsipocz commented Nov 27, 2021

Yes, everything should be handled by setup.cfg now. RTD picks up the docs dependencies from the options.extras_require section, too (see #2229) while pip also works with that file automatically, so we don't need to maintain the dependency lists at multiple locations (well, we still need to update the narrative docs whenever we drop/add something, but at least there are no multiple config files floating around).

@bsipocz bsipocz merged commit a444e76 into astropy:main Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants