Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #2237: do not cache results that cannot be parsed. #2253

Merged
merged 2 commits into from
Dec 25, 2021

Conversation

mkelley
Copy link
Contributor

@mkelley mkelley commented Dec 20, 2021

Address #2237 by catching result parse errors and removing the corresponding cached file, if applicable. Also add a mock test to that effect.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2253 (55d6619) into main (17c79f9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2253      +/-   ##
==========================================
+ Coverage   62.40%   62.44%   +0.03%     
==========================================
  Files         131      131              
  Lines       16777    16785       +8     
==========================================
+ Hits        10470    10481      +11     
+ Misses       6307     6304       -3     
Impacted Files Coverage Δ
astroquery/jplhorizons/core.py 66.34% <100.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c79f9...55d6619. Read the comment docs.

@mkelley mkelley changed the title Fix for issue #2237: do not cache results that cannot be parsed. WIP: Fix for issue #2237: do not cache results that cannot be parsed. Dec 20, 2021
@mkelley mkelley changed the title WIP: Fix for issue #2237: do not cache results that cannot be parsed. Fix for issue #2237: do not cache results that cannot be parsed. Dec 20, 2021
@bsipocz bsipocz added this to the v0.4.5 milestone Dec 20, 2021
@bsipocz bsipocz merged commit e500566 into astropy:main Dec 25, 2021
@bsipocz
Copy link
Member

bsipocz commented Dec 25, 2021

Thanks @mkelley!

@mkelley mkelley deleted the jplhorizons-failed-query-cache branch January 7, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants