Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LAMDA writer fails on windows and python3 #894

Closed
wants to merge 3 commits into from
Closed

LAMDA writer fails on windows and python3 #894

wants to merge 3 commits into from

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 18, 2017

This fail was hidden in #887 as the last commit had skip ci in its message and thus got an all green.

https://ci.appveyor.com/project/Astropy/astroquery/build/1.0.520/job/mvlsvj9ibrd53ecv#L936

@bsipocz
Copy link
Member Author

bsipocz commented Apr 18, 2017

@keflavich - I could push a commit to this issue and make it a PR (using issue2pr.py). However it was my own issue, I'll try to find another one opened by someone else to test it further.

@bsipocz bsipocz force-pushed the lambda_writer_windows_fix branch 15 times, most recently from a41a136 to 62a0cdd Compare April 19, 2017 17:14
@bsipocz bsipocz mentioned this pull request Apr 19, 2017
Closed
@bsipocz
Copy link
Member Author

bsipocz commented Apr 19, 2017

@keflavich - FYI this is a bug in astropy on py3 windows astropy/astropy#5126

bsipocz added a commit to bsipocz/astroquery that referenced this pull request May 5, 2017
@bsipocz
xfailing the lamda writer for windows and py3 until astropy#894 is so…
a6f7a99 
…lved
bsipocz added a commit to bsipocz/astroquery that referenced this pull request May 5, 2017
@bsipocz
xfailing the lamda writer for windows and py3 until astropy#894 is so…
e7ee4f6 
…lved
@bsipocz bsipocz force-pushed the lambda_writer_windows_fix branch from a1ff561 to 2897dec Compare May 11, 2017 23:00
@bsipocz bsipocz closed this May 11, 2017
@bsipocz bsipocz reopened this May 11, 2017
@bsipocz bsipocz mentioned this pull request May 12, 2017
Closed
@bsipocz
Copy link
Member Author

bsipocz commented May 12, 2017

@pep8speaks suggest a diff

OrkoHunter
OrkoHunter reviewed May 12, 2017
View reviewed changes
Copy link

@OrkoHunter OrkoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pep8speaks suggest a diff

@pep8speaks
Copy link

Here you go with the gist !

You can ask me to create a PR against this branch with those fixes. Submit a review comment as @pep8speaks pep8ify.

@OrkoHunter @bsipocz

@OrkoHunter
Copy link

@bsipocz Currently the commands are implemented as a review comment (and not general comment like your last one). Normal comments have a different API than the review comments and I'll work on to get it working very soon :)
pep8speaks-org/pep8speaks#36

@bsipocz
Copy link
Member Author

bsipocz commented May 12, 2017

@OrkoHunter - Thanks, good to know.

@astropy-bot
Copy link

astropy-bot bot commented Jul 4, 2017 •
edited
Loading

Thanks for updating the pull request @bsipocz!

I noticed the following issue with this pull request:

  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix this? Thanks!

@bsipocz bsipocz added this to the 0.3.7 milestone Jul 4, 2017
@bsipocz bsipocz modified the milestones: v0.3.7, v0.3.8 Jan 24, 2018
@astropy-bot
Copy link

astropy-bot bot commented Jan 24, 2018 •
edited
Loading

Hi there @bsipocz 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

I noticed the following issue with this pull request:

  • Changelog entry not present (or pull request number missing) and neither the Affects-dev nor the no-changelog-entry-needed label are set

Would it be possible to fix this? Thanks!

If there are any issues with this message, please report them here.

@migueldvb
Copy link
Member

Sorry that I missed this issue. I think that the problem is now fixed in migueldvb:lamda_windows (migueldvb@fad5a39). @bsipocz do you want to merge the change to this PR?

migueldvb added a commit to migueldvb/astroquery that referenced this pull request Feb 28, 2018
@migueldvb
Revert "xfailing the lamda writer for windows and py3 until astropy#894…
3e9ee5b 
… is solved"

This reverts commit e7ee4f6.
migueldvb added a commit to migueldvb/astroquery that referenced this pull request Feb 28, 2018
@migueldvb
Revert "xfailing the lamda writer for windows and py3 until astropy#894…
d013fd0 
… is solved"

This reverts commit e7ee4f6.
@migueldvb
Copy link
Member

This issue has a workaround in #1059

@migueldvb migueldvb mentioned this pull request Mar 12, 2018
Merged
@migueldvb
Copy link
Member

This has been fixed in master and the PR can be closed now.

@keflavich keflavich closed this Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrkoHunter OrkoHunter OrkoHunter left review comments

Assignees
No one assigned
Labels
bug lamda python3 Upstream windows
Projects
None yet
Milestone
v0.3.8
Development

Successfully merging this pull request may close these issues.
5 participants
@bsipocz @pep8speaks @OrkoHunter @migueldvb @keflavich