-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Do not write config on import #768
Conversation
Codecov Report
@@ Coverage Diff @@
## main #768 +/- ##
==========================================
+ Coverage 95.51% 95.93% +0.42%
==========================================
Files 30 30
Lines 3944 3909 -35
==========================================
- Hits 3767 3750 -17
+ Misses 177 159 -18
Continue to review full report at Codecov.
|
# auto_logging = True | ||
# Whether to automatically log operations to metadata | ||
# If set to False, there is no need to specify add_keyword=False | ||
# when calling processing operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As ccdproc has some custom config items, this should be documented using the sphinx extension: https://github.com/astropy/sphinx-astropy/blob/main/sphinx_astropy/ext/generate_config.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call, @saimn . Added a commit. How does it look now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
ccdproc/_astropy_init.py
Outdated
|
||
|
||
if not _ASTROPY_SETUP_: | ||
if not _ASTROPY_SETUP_: # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be removed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed. What about now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, merging!
This functionality will be deprecated in
astropy
in a future release. See astropy/astropy#11497 and https://groups.google.com/g/astropy-dev/c/KVzPgeihxO8Bonus: Clean up test runner code.