Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Do not write config on import #768

Merged
merged 4 commits into from
May 19, 2021
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Apr 9, 2021

This functionality will be deprecated in astropy in a future release. See astropy/astropy#11497 and https://groups.google.com/g/astropy-dev/c/KVzPgeihxO8

Bonus: Clean up test runner code.

@pllim pllim requested review from saimn and mwcraig April 9, 2021 21:59
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #768 (c730375) into main (40bafe7) will increase coverage by 0.42%.
The diff coverage is 100.00%.

❗ Current head c730375 differs from pull request most recent head 3fda41e. Consider uploading reports for the commit 3fda41e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   95.51%   95.93%   +0.42%     
==========================================
  Files          30       30              
  Lines        3944     3909      -35     
==========================================
- Hits         3767     3750      -17     
+ Misses        177      159      -18     
Impacted Files Coverage Δ
ccdproc/__init__.py 100.00% <100.00%> (+11.76%) ⬆️
ccdproc/_astropy_init.py 75.00% <100.00%> (+23.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40bafe7...3fda41e. Read the comment docs.

# auto_logging = True
# Whether to automatically log operations to metadata
# If set to False, there is no need to specify add_keyword=False
# when calling processing operations
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As ccdproc has some custom config items, this should be documented using the sphinx extension: https://github.com/astropy/sphinx-astropy/blob/main/sphinx_astropy/ext/generate_config.py

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, @saimn . Added a commit. How does it look now?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍



if not _ASTROPY_SETUP_:
if not _ASTROPY_SETUP_: # noqa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be removed too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed. What about now?

Copy link
Member

@mwcraig mwcraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merging!

@mwcraig mwcraig merged commit 57992b0 into astropy:main May 19, 2021
@pllim pllim deleted the config-no-update branch May 19, 2021 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants