Ia #1056
Merged
Ia #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ia correlations
…t makes the power law more readable
…ing SubhaloAlignment as the alignmnet module
…e to used subhalo columns instead
…l axes if there was one bad value
…tring label but instead requires str
Trivial merge
…nput vectors resulted in nan values
Trivial merge
…e marked_npairs_xy_z file instead of marked_npairs_3d
… to be rotated by a corresponding rotation matrix in a list of matrices
Adjusted subhalo_prop_dict needed for SubhaloAlignment and adjusted t…
|
@aphearin @nvanalfen just curious, what is the status of merging all IA stuff? I'd like to use it for a project and would be very happy to be able to just use the main branch of halotools :-) |
|
@EiffL it is "ready to go". And by that I mean the code is ready to merge, but we're holding off until the methods paper for it is set to publish. |
Pulling bug fixes from official halotools master
Merging bug fixes from astropy
|
@aphearin assuming the CI passes, everything should be good to go on my end. Let me know if you have any concerns. Otherwise, the PR is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include IA functionality in halotools. Adds the ability to align galaxies in the HOD models as well as to measure IA correlations. Paper published in the Open Journal of Astrophysics here.