divide by zero bug in elliptical_exact.pyx #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know when this got introduced, but I'm getting failed tests due to this function in
elliptical_exact.pyx
:When
x1 == x2
(which happens for vertical lines of course) this give a divide by zero error.Actually I'm also getting failed tests on master having to do with the changing API for
encloses
methods, but that will be resolved in my PR #11.