Revised algorithm to no longer be affected by floating point precision #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm still seeing failures, but I've managed to reproduce the issue on a 32-bit linux VM, so will debug. |
|
Awesome, it looks like the bug has been fixed :-) I'll wait for the last few tests to run, then I'll merge. |
astrofrog
added a commit
that referenced
this pull request
Dec 3, 2012
Revised algorithm to no longer be affected by floating point precision
This was referenced Dec 3, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the floating point issues in #15 and #16, I tried to revise how the algorithm works for exact elliptical aperture photometry, in order to no longer be affected so much by floating point accuracy (e.g. 1e-17 vs 0, etc.). Let's see if this passes on Travis.