Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a test case for radio cubes #113

Merged
merged 3 commits into from
Oct 13, 2017
Merged

add a test case for radio cubes #113

merged 3 commits into from
Oct 13, 2017

Conversation

leejjoon
Copy link
Contributor

This is a simple test case for a header of 3d cube.

keflavich
keflavich approved these changes May 15, 2017
View reviewed changes
pyregion/tests/examples/sample_fits03.header Outdated
@@ -0,0 +1,21 @@
SIMPLE = T /
BITPIX = -32 / NAXIS = 3 /
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing newline?

@leejjoon leejjoon mentioned this pull request May 15, 2017
Open
@leejjoon
add a test case for radio cubes
a4983ec 
remove trailing spaces in sample_fits03.header

fix header path
@coveralls
Copy link

Coverage Status

Coverage remained the same at 63.295% when pulling a4983ec on leejjoon:fix-cube2 into 7ad0106 on astropy:master.

@cdeil cdeil added this to the 2.0 milestone May 17, 2017
@cdeil cdeil added the tests label May 17, 2017
@cdeil
Copy link
Member

cdeil commented May 17, 2017

@leejjoon - Thanks!

I plan to make the pyregion 2.0 release tomorrow and this is ready to go in.
If you have time, one suggestion I have would be to add an assert (using numpy.testing.assert_allclose on the result, at the end of the test (to establish the current behaviour).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 63.504% when pulling 918fcb0 on leejjoon:fix-cube2 into 7ad0106 on astropy:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 63.504% when pulling 48a14d5 on leejjoon:fix-cube2 into 7ad0106 on astropy:master.

@cdeil cdeil mentioned this pull request Aug 3, 2017
Closed
@cdeil
Copy link
Member

cdeil commented Oct 13, 2017

@leejjoon - I'm merging in this old PR from you now. Thanks!

@cdeil cdeil merged commit 7bde9dd into astropy:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keflavich keflavich keflavich approved these changes

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@leejjoon @coveralls @cdeil @keflavich