Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle description of None when describing a TAP service's tables #197

Merged
merged 4 commits into from
Dec 17, 2019

Conversation

stargaser
Copy link
Contributor

This small PR is to address an issue we have found in describing available tables from a TAP service, when a description is not provided.

To test:

import pyvo as vo
irsa_services = vo.regsearch(servicetype='table', keywords=['irsa'])
irsa_tap = irsa_services[0]
irsa_tap.service.tables.describe()

The fix in the PR is to print No description instead of raising an exception.

Copy link
Contributor

@cbanek cbanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbanek cbanek added this to the v1.1 milestone Dec 12, 2019
@cbanek
Copy link
Contributor

cbanek commented Dec 12, 2019

Since this is a user facing kind of thing, might want to add an entry to the CHANGELOG (although I'm also fine if we think this is below that bar, we can add the flag no-changelog-entry-needed)

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #197 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   70.81%   70.91%   +0.09%     
==========================================
  Files          37       37              
  Lines        3910     3912       +2     
==========================================
+ Hits         2769     2774       +5     
+ Misses       1141     1138       -3
Impacted Files Coverage Δ
pyvo/io/vosi/vodataservice.py 84.55% <100%> (+0.87%) ⬆️
pyvo/io/uws/endpoint.py 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef3dd30...6fad216. Read the comment docs.

@stargaser
Copy link
Contributor Author

I feel like I should add a test. Looks like I should make an analog of tests/data/tables/multiple_table_descriptions.xml that is missing_table_description.xml and then add a test using that file. Does that make sense?

@stargaser
Copy link
Contributor Author

Cross-referencing NASA-NAVO/workshop-dev#5 where we noticed the problem addressed in this PR.

@stargaser
Copy link
Contributor Author

Huh, looks like codecov/project increased by adding the test, but codecov/patch went down. I'm puzzled.

@cbanek cbanek merged commit d32a6de into astropy:master Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants