-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle description of None when describing a TAP service's tables #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Since this is a user facing kind of thing, might want to add an entry to the CHANGELOG (although I'm also fine if we think this is below that bar, we can add the flag no-changelog-entry-needed) |
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
+ Coverage 70.81% 70.91% +0.09%
==========================================
Files 37 37
Lines 3910 3912 +2
==========================================
+ Hits 2769 2774 +5
+ Misses 1141 1138 -3
Continue to review full report at Codecov.
|
I feel like I should add a test. Looks like I should make an analog of |
Cross-referencing NASA-NAVO/workshop-dev#5 where we noticed the problem addressed in this PR. |
Huh, looks like codecov/project increased by adding the test, but codecov/patch went down. I'm puzzled. |
3b9773c
to
6fad216
Compare
This small PR is to address an issue we have found in describing available tables from a TAP service, when a description is not provided.
To test:
The fix in the PR is to print
No description
instead of raising an exception.