Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #200 - treat keywords str value as single keyword #201

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

tomdonaldson
Copy link
Contributor

This addresses a usability issue with regsearch() where if one mistakenly supplies a single str as the keywords value, too many results are returned.

@tomdonaldson tomdonaldson added this to the v1.1 milestone Dec 18, 2019
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #201 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   70.91%   70.92%   +0.01%     
==========================================
  Files          37       37              
  Lines        3912     3914       +2     
==========================================
+ Hits         2774     2776       +2     
  Misses       1138     1138
Impacted Files Coverage Δ
pyvo/registry/regtap.py 44.18% <100%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32a6de...6b02d3d. Read the comment docs.

Copy link
Contributor

@cbanek cbanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I agree it doesn't make a lot of sense to treat a string like an array of chars. Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants