Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Replace master with main #253

Merged
merged 2 commits into from
Dec 18, 2021
Merged

Conversation

pllim
Copy link
Member

@pllim pllim commented Mar 9, 2021

This PR attempts to replace all mention of master to main in this repository. This should be reviewed and merged right after the maintainer has renamed the default branch.

This is an automated update made by the batchpr tool 🤖 - feel free to close if it doesn't look good! You can report issues to @pllim.

This is part of #252

@pllim
Copy link
Member Author

pllim commented Mar 9, 2021

Does depend on ci-helpers renaming.

@codecov
Copy link

codecov bot commented Dec 18, 2021

Codecov Report

Merging #253 (8091abb) into master (f72aa90) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   75.51%   75.51%           
=======================================
  Files          44       44           
  Lines        5129     5129           
=======================================
  Hits         3873     3873           
  Misses       1256     1256           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f72aa90...8091abb. Read the comment docs.

@bsipocz
Copy link
Member

bsipocz commented Dec 18, 2021

I've rebased this, and it should be ready to go now -- merging should coincide with changing the settings on the repo though.

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for doing this!

@bsipocz bsipocz merged commit 5d4ab7c into astropy:master Dec 18, 2021
@bsipocz
Copy link
Member

bsipocz commented Dec 18, 2021

Thanks @pllim

And now I go ahead and update the repo settings. Long term we should think about having the "pyvo maintainers" group have admin access to have the ability to edit the repo settings and do the release without interactions from the devops team. Opting in to more branch protection would provide enough safeguard against accidental pushes to the main branch, etc.

@pllim pllim deleted the replace-with-main branch December 20, 2021 13:40
@tomdonaldson tomdonaldson modified the milestones: v1.3, v1.2.1 Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants