update requirements

[olaurino]

When I started working with the repo I couldn't install all the dependencies right away and I had to figure out what I needed for testing, so I thought I'd create a little PR with the changes I made.

• add pillow to the list of extra requirements. However note that one of the tests fails without pillow. Should the test be skipped if pillow is not installed?
• add requests-mock to the list of test dependencies.

Also remove a left over pip-requirements file and fix #310

• Review the README
• Review the installation docs

[codecov]

Codecov Report

Merging #308 (b145874) into main (7a0b7da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #308   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          44       44           
  Lines        5125     5125           
=======================================
  Hits         3869     3869           
  Misses       1256     1256           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[bsipocz]

The PR (#290) that switched to the new build system missed to update the docs, and I would suggest to update the install the dev version session and to add this new test related one to rely solely on the info in setup.cfg, as in my experience adding new requirements files is a chance for getting them off sync over time. I would also suggest to remove the pip_requirements file, I think it's accidentally left in there as it's not being used anywhere.

So, the syntax to get all you need for testing:

pip install -e .[test]

For building the docs:

pip install -e .[docs]

And getting all optional dependencies:

pip install -e .[all]

These should of course work with non executable dev versions when changing -e . to pyvo. If there are any dependencies that are still missing after running these commands, those should be added to the appropriate section of [options.extras_require].

[olaurino]

@bsipocz thanks. I'll try again with the info you provided. I was indeed confused by all the different files.

[bsipocz]

I think the README needs updating, though. It mentions running setup.py directly.

yes, that was a mistake in the review of the PR that we didn't spot that the documentation was missed out from the updates.

[olaurino]

@bsipocz well this was fun. I hadn't had the luxury to work with a python only system in a while. Only conda for a long time! The sphinx installation documentation seems very basic. Is it enough to replace python setup.py install with pip install and maybe add a line or two on running the tests?

[bsipocz]

The sphinx installation documentation seems very basic. Is it enough to replace python setup.py install with pip install and maybe add a line or two on running the tests?

I think it's enough, but it's really you who can tell what would have been enough info to help you get set up.

[andamian]

This looks good to me.

[andamian]

Thanks for the contribution @olaurino