Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding devtest description to the docs #316

Merged
merged 3 commits into from
May 9, 2022

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Apr 28, 2022

Also added a requirements section

@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #316 (362e7f1) into main (b39eef7) will not change coverage.
The diff coverage is n/a.

❗ Current head 362e7f1 differs from pull request most recent head 13b2034. Consider uploading reports for the commit 13b2034 to get more accurate results

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   75.49%   75.49%           
=======================================
  Files          44       44           
  Lines        5125     5125           
=======================================
  Hits         3869     3869           
  Misses       1256     1256           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@bsipocz bsipocz requested a review from andamian April 28, 2022 18:22
@bsipocz bsipocz added this to the v1.3.1 milestone May 2, 2022
* `pytest-astropy <https://github.com/astropy/pytest-astropy>`__
* requests-mock
* `sphinx-astropy <https://github.com/astropy/sphinx-astropy>`__

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great but I would start with the easy options first: pip. Also, it should mention that it's distributed with Conda too. Only after this, I would go with these details.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hahh, I landed in the 🐰 🕳️ . I really just wanted to list the necessary info for those building from source, but will add a mention of conda, too.

Copy link
Contributor

@andamian andamian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bsipocz!

@andamian andamian merged commit d028f40 into astropy:main May 9, 2022
@bsipocz bsipocz modified the milestones: v1.3.1, v1.4 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants