Fixes datalinks in scs (#320) by changing order of parent classes in dal.scs.SCSResults #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoghbi-a
changed the title
zoghbi-a
changed the title
msdemlei
approved these changes
May 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 75.49% 75.49%
=======================================
Files 44 44
Lines 5125 5125
=======================================
Hits 3869 3869
Misses 1256 1256
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
As it turns out, there is a pending PR #293 that also addresses the issue. That one also includes the passing of sessions and that caused me to miss the link between the two fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of inheritance is changes for SCSResult to fix issue #320.