Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid AttributeError in DALServiceError.from_except #392

Merged
merged 1 commit into from
Jan 5, 2023

Conversation

JannisNe
Copy link
Contributor

@JannisNe JannisNe commented Jan 3, 2023

If the response is None we get the AttributeError from L.187 in pyvo.dal.exceptions.
This is related to #376 .

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It certainly would be nice to have a test exercising that, but since it clearly improves current misbehaviour, I'd merge it as-is.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #392 (0193e66) into main (2ada636) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   79.96%   79.96%           
=======================================
  Files          52       52           
  Lines        5969     5969           
=======================================
  Hits         4773     4773           
  Misses       1196     1196           
Impacted Files Coverage Δ
pyvo/dal/exceptions.py 85.00% <75.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants