Fixing a query generation for the epn-tap data model.

[msdemlei]

This closes bug #393

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (main@cc97126). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head c7ad518 differs from pull request most recent head 4fc8d11. Consider uploading reports for the commit 4fc8d11 to get more accurate results

@@           Coverage Diff           @@
##             main     #395   +/-   ##
=======================================
  Coverage        ?   79.96%           
=======================================
  Files           ?       52           
  Lines           ?     5969           
  Branches        ?        0           
=======================================
  Hits            ?     4773           
  Misses          ?     1196           
  Partials        ?        0           

Impacted Files	Coverage Δ
pyvo/registry/rtcons.py	97.67% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rsav]

I have tested this PR and this works for me:
registry.search(registry.Datamodel('epntap'))
now retrieves 244 rows.
Thanks msdemlei !

[andamian]

Isn't this a simpler way to check for the expected warning in the set?

Suggested change

	# the following test is written this oddly to avoid that extra
	# warnings break it.
	expectation = set(
	['The resource ivo://pyvo/test_regtap.py has multipl'])
	assert set(str(w.message)[:50] for w in recwarn
	) & expectation == expectation
	assert 'The resource ivo://pyvo/test_regtap.py has multipl' in [str(w.message)[:50] for w in recwarn]

[bsipocz]

This feels a bit over engineered, any reasons not to use the pytest.warns context in tests?

[msdemlei]

On Tue, Jan 10, 2023 at 10:49:43AM -0800, Adrian wrote: ```suggestion assert 'The resource ivo://pyvo/test_regtap.py has multipl' in [str(w.message)[:50] for w in recwarn] ```

Fair enough. Force-pushed the change. Thanks!

[andamian]

It looks good except for the style issues.

[bsipocz]

Given this is a user reported bug and also present in the latest release, it should have a changelog entry.

[msdemlei]

On Wed, Jan 11, 2023 at 03:43:09PM -0800, Brigitta Sipőcz wrote: Given this is a user reported bug and also present in the latest release, it should have a changelog entry.

Added one, force-pushed. @andamian: is that the style issue you were mentioning? If so, would you merge? Thanks!

[andamian]

The style check action is still not green in CI. Check https://github.com/astropy/pyvo/actions/runs/3900161110/jobs/6660548272

[msdemlei]

On Thu, Jan 12, 2023 at 01:45:43AM -0800, Adrian wrote: The style check action is still not green in CI. Check https://github.com/astropy/pyvo/actions/runs/3900161110/jobs/6660548272

Ah dang, missed that. I'll need to fix my commit routine...

[bsipocz]

Given this is all approved, I'll just go ahead and fix the minor issue and changelog conflict and merge it.

[bsipocz]

Thanks @msdemlei for the fix!

[msdemlei]

On Tue, Jan 24, 2023 at 11:22:40AM -0800, Brigitta Sipőcz wrote: Given this is all approved, I'll just go ahead and fix the minor issue and changelog conflict and merge it.

Thanks! (And sorry for having missed the problem).