No longer discarding single untyped interfaces. #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 79.96% 79.97%
=======================================
Files 52 52
Lines 5971 5972 +1
=======================================
+ Hits 4775 4776 +1
Misses 1196 1196
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This fixes an (unreported) bug where, when there is just a single interface of a single capability of a service and that is missing either a type or a role, it would get discarded as a consequence of the way we work around VOTable's lack of proper string arrays.
msdemlei
force-pushed
the
do-not-discard-single-untyped-interfaces
branch
from
c7655c8
to
8d0d6f5
Compare
bsipocz
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
All looks good, thanks @msdemlei for the fix.
I'm going back and forth with the changelog entry, it's very much on the borderline. as it's unreported and very unlikely that anyone relied on the buggy behaviour added in 1.4, I would treat it as affects-dev.
|
Thanks @msdemlei! |
bsipocz
added a commit
that referenced
this pull request
Mar 7, 2023
…terfaces No longer discarding single untyped interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an (unreported) bug where, when there is just a single interface of a single capability of a service and that is missing either a type or a role, it would get discarded as a consequence of the way we work around VOTable's lack of proper string arrays.
Not sure if this (minor -- the services pyVO actually cares about all have types and roles) bug fix warrants a changelog entry. Let me know if you want one.