Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix typo in default #421

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Feb 15, 2023

Hmm, I added this typo and bug in #367, so here is an affect-dev fix for it.

Unfortunately, pyvo's test suite wasn't picked up on it, but it caused test failures for multiple https://github.com/NASA-NAVO/navo-workshop notebooks.

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomdonaldson tomdonaldson merged commit 03d5541 into astropy:main Feb 15, 2023
bsipocz pushed a commit that referenced this pull request Mar 7, 2023
@bsipocz bsipocz deleted the BUG_SSA_fix_typo_in_default branch April 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants