Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: restructure tests to use parametrize rather than internal loop #462

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Jul 25, 2023

Bumped into this test while doing #459, so systematically looked for cases where parametrize should be used instead of internal loops. Opening it as a separate PR as this supposed to be a trivial refactoring.

@bsipocz bsipocz added this to the v1.4.2 milestone Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #462 (625bec5) into main (9e8f602) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #462   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          52       52           
  Lines        6020     6020           
=======================================
  Hits         4821     4821           
  Misses       1199     1199           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bsipocz bsipocz merged commit c5b1fe1 into astropy:main Jul 26, 2023
9 of 10 checks passed
bsipocz added a commit that referenced this pull request Aug 16, 2023
TST: restructure tests to use parametrize rather than internal loop
@bsipocz bsipocz deleted the tests_use_parametrize branch October 20, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants