MAINT: add workaround for doctesting with new numpy repr #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
reviewed
Jul 26, 2023
pyvo/conftest.py
Outdated
| @@ -15,6 +16,8 @@ | |||
| except ImportError: | |||
| ASTROPY_HEADER = False | |||
|
|
|||
| # Keep this until we require numpy to be >=2.0 | |||
| np.set_printoptions(legacy="1.25") | |||
There was a problem hiding this comment.
Do you need a numpy version check before calling it?
There was a problem hiding this comment.
CI says that apparently I do 😅
Codecov Report
@@ Coverage Diff @@
## main #465 +/- ##
=======================================
Coverage 80.08% 80.08%
=======================================
Files 52 52
Lines 6020 6020
=======================================
Hits 4821 4821
Misses 1199 1199 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pllim
reviewed
Jul 26, 2023
|
Note that online test failure is expected and is taken care of in a separate PR already. |
bsipocz
force-pushed
the
test_workaround_new_np_repr
branch
from
d9f1640
to
bdea8e1
Compare
|
(messing with the changelog label to test the GHA) |
This was referenced Jul 26, 2023
bsipocz
added a commit
that referenced
this pull request
Aug 16, 2023
MAINT: add workaround for doctesting with new numpy repr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #464 and fix the CI failure we see in the devtest job.