Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: votable.tree.Table was renamed to TableElement #496

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Oct 20, 2023

Follow-up on astropy/astropy#15372

@bsipocz bsipocz added this to the v1.4.3 milestone Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #496 (5b280e4) into main (d564bc4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage   80.08%   80.08%           
=======================================
  Files          52       52           
  Lines        6066     6066           
=======================================
  Hits         4858     4858           
  Misses       1208     1208           
Files Coverage Δ
pyvo/dal/adhoc.py 66.27% <ø> (ø)
pyvo/dal/query.py 84.81% <ø> (ø)
pyvo/dal/scs.py 68.57% <ø> (ø)
pyvo/dal/sia.py 62.44% <ø> (ø)
pyvo/dal/sia2.py 76.96% <ø> (ø)
pyvo/dal/sla.py 64.54% <ø> (ø)
pyvo/dal/ssa.py 53.53% <ø> (ø)
pyvo/dal/tap.py 73.44% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@bsipocz bsipocz merged commit 6670522 into astropy:main Oct 20, 2023
12 checks passed
@bsipocz bsipocz modified the milestones: v1.4.3, v1.5 Dec 15, 2023
@bsipocz bsipocz deleted the DEP_Table_vs_TableElement branch April 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants