DEP: temporarily using dev version of indirect dependency pyerfa #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ake the devtesting job pass
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
=======================================
Coverage 80.08% 80.08%
=======================================
Files 52 52
Lines 6071 6071
=======================================
Hits 4862 4862
Misses 1209 1209 ☔ View full report in Codecov by Sentry. |
pllim
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
I think astropy.utils.iers imports erfa stuff no matter what, so that in turn imports their C-extension, and triggers the numpy-dev stuff when you have numpy-dev and astropy-dev installed but not pyerfa-dev.
Once numpy 2.0 stable is out and both pyerfa has a stable version that is built with numpy 2.0 on PyPI, indeed, this won't be necessary anymore. But it also does not hurt to keep it going forward.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we need to make this hack to make the dev testing work. (It's a hack as pyerfa is not our direct dependency but astropy's, I'm not even sure we use any features in pyvo that requires erfa)