Adding support for VODataService 1.2 table/@nrows. #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msdemlei
force-pushed
the
add-nrows-to-vosi-tables
branch
from
599dd5d
to
2d15096
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
+ Coverage 80.08% 80.11% +0.02%
==========================================
Files 52 52
Lines 6077 6085 +8
==========================================
+ Hits 4867 4875 +8
Misses 1210 1210 ☔ View full report in Codecov by Sentry. |
bsipocz
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.2, VODataService added an nrows attribute to the tables element (cf. https://ivoa.net/documents/VODataService/20211102/REC-VODataService-1.2.html#tth_sEcA.4).
This PR adds support for this attribute, which in particular fixes warnings that spoil our tests when accessing the GAVO RegTAP endpoint with PR #386.