Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: fix backward compatibility in preparation for release #509

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Dec 19, 2023

This should fix API backward compatibility noticed in #495 (review)

@bsipocz bsipocz added the Affects-dev To be used for follow-up PRs for new engancements or bugs only present on dev label Dec 19, 2023
@bsipocz bsipocz added this to the v1.5 milestone Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c49a408) 80.28% compared to head (ca50ecf) 80.28%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files          52       52           
  Lines        6152     6152           
=======================================
  Hits         4939     4939           
  Misses       1213     1213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomdonaldson tomdonaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @bsipocz!

@bsipocz bsipocz merged commit 329ecb5 into astropy:main Dec 19, 2023
11 of 13 checks passed
@bsipocz bsipocz deleted the API_rtcons_bkward_compat branch April 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects-dev To be used for follow-up PRs for new engancements or bugs only present on dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants