-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added general API tests #20
Conversation
@astrofrog - Can you please rebase this to trigger tests to run again. Also -- what's the plan here? |
@astrofrog Do you have time to finish up this PR in the next two days for the 0.1 release? Or should we punt this one to the 0.2 milestone? |
@cdeil - I've just rebased and now made sure that methods that return Note that there are some genuine failures, either due to my lack of understanding of the API for certain tests, or real issues with different methods. I don't have time to look at this in the short term, but if someone else could take a look and do a PR to my branch to fix the real failures, then I can merge that in and we can make sure this makes it to 0.1. Some of the failures I saw are definitely of the kind that we should investigate before any release. |
@astrofrog - I agree it would be very good to get this in for 0.1. I'll have a look at the fails now and try to fix them. |
@astrofrog - Locally this makes all tests pass for me: I guess the main question is if / how One more question: what about the "Table of doom" at the top? Does it make sense to copy it to a separate issue? |
IMHO it should do what SkyCoord does behavior wise? (that is, it should be able to represent scalar and vector coordinates). I can't remember if SkyCoord actually stores everything as a numpy array though, I think it does. |
I agree moving the table to the wiki makes sense - can try and do that later today |
Misc fixes to make test_api pass
travis-ci tests passed. |
@@ -13,7 +13,7 @@ environment: | |||
# For this package-template, we include examples of Cython modules, | |||
# so Cython is required for testing. If your package does not include | |||
# Cython code, you can set CONDA_DEPENDENCIES='' | |||
CONDA_DEPENDENCIES: "Cython" | |||
CONDA_DEPENDENCIES: "Cython shapely" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Appveyor build fails because shapely is not available in this conda channel:
https://ci.appveyor.com/project/Astropy/regions/build/1.0.74/job/wfb95tev3c94p9jh#L81
@astrofrog - Do you know how to fix this? If no, please remove shapely here and let's move the Windows shapely install issue to a separate future issue.
@astrofrog - Could you please merge this PR soon? I'd like to do some more PRs on |
@cdeil - I'm overloaded today and tomorrow - since you have merge privileges, can you merge this and make the fixes you need to make in a separate PR? |
@cdeil - actually let me push a fix for shapely, can do it now |
Merging this now. Thanks, @astrofrog ! I'll continue with |
Still trying to figure out how to turn this into a markdown table...
Table of doom: