Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cython version used in pyproject.toml #337

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

astrofrog
Copy link
Member

I think this might fix some of the Windows CI issues

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #337 (6af66c6) into main (91034a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #337   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files          33       33           
  Lines        2508     2508           
=======================================
  Hits         2304     2304           
  Misses        204      204           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91034a7...6af66c6. Read the comment docs.

@larrybradley
Copy link
Member

The test failures look real. TestEllipsePixelRegion.test_as_mpl_selector is expecting a center of 8.3, but getting 5.0.
https://dev.azure.com/astropy-project/regions/_build/results?buildId=1146&view=logs&j=7f33e5bd-7764-5d8a-ba2e-506e078b9c3f&t=57e5be12-0a85-50b9-0e83-1cf5152ef732&l=218

@astrofrog
Copy link
Member Author

I wonder if this is related to some changes in Matplotlib

@astrofrog
Copy link
Member Author

I can't reproduce the issue locally, I wonder whether there is some kind of race condition in the interactivity or if we somehow need to force everything to be drawn before checking values.

@astrofrog
Copy link
Member Author

This does fix the docs build which had the Cython issues though so going to merge this and we should investigate the selector test issues separately (these happen even without the Cython upgrade)

@astrofrog astrofrog merged commit 120e756 into astropy:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants