-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for ds9 region parser #7
Conversation
@keflavich I added tests that read the fk5, galactic, and physical input files and creates reference files (checked by hand). I guess that is sufficient to start playing with the parsers. What do you think? |
Yes, the testing structure looks good. Any other interesting failure points along the way? |
Trigger more travis things...
no more deprecation exceptions!
Changes Unknown when pulling d7d1ae0 on joleroi:region_tests into * on astropy:master*. |
Changes Unknown when pulling d7d1ae0 on joleroi:region_tests into * on astropy:master*. |
Changes Unknown when pulling 9f9c3fd on joleroi:region_tests into * on astropy:master*. |
Changes Unknown when pulling 6c01e44 on joleroi:region_tests into * on astropy:master*. |
Changes Unknown when pulling 6c01e44 on joleroi:region_tests into * on astropy:master*. |
Changes Unknown when pulling ae9e624 on joleroi:region_tests into * on astropy:master*. |
@keflavich |
@joleroi Looks like you're right. We should ask @mwcraig about the astropy versions linked to older numpy versions on conda: they seem on the old side (1.0.3<->1.8, 1.0.4<->1.9). However, the solution is to do a version check in the testing and use |
Changes Unknown when pulling f9883a3 on joleroi:region_tests into * on astropy:master*. |
One test fixed -> 2 others fail 😁 Seem like StrictVersion does not like the astropy dev version strings ... |
Ah, that's true... maybe we need |
Changes Unknown when pulling ab7a4c4 on joleroi:region_tests into * on astropy:master*. |
Checks pass |
Would it be possible to merge this today so that people (specifically me) can start playing with this? |
Yes, reviewing. |
👍 |
This is a continuation of #5
Addressing the 'correctness test'