-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add high-level docs for compound regions #74
Conversation
@joleroi - Thanks! I put a version of the docs here: Currently (for me, on Python 3 with latest Astropy), the plot looks like this: Should there be points outside the regions? Travis-ci fails are unrelated, I think: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two minor inline comments.
... radius=Angle('3 deg'), | ||
... ) | ||
>>> type(circle1 & circle2) | ||
... regions.core.compound.CompoundSkyRegion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually one puts stuff as it would appear in the Python console.
I.e. only put ...
for input.
This line is output and should not have ...
or be indented.
Same for print statement below.
@@ -0,0 +1,69 @@ | |||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a one-line description at the top of every new file.
People will copy & paste it and then it's good to have a one-line description if they find it in their Download folder a month later.
Something like:
"""
Example script illustrating compound regions.
"""
@cdeil I can hit |
I don't think there should be points outside the regions. I check manually for the following point
It is marked in red (and called I am pretty sure that it is really and XOR point so the compound region
So I guess there is some unwanted behaviour in the plotting method of |
Looks like a sky circle matplotlib plotting issue to me. |
The test failures are not related to changes in this PR, see e.g. |
This PR
Ready for review