Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package infrastructure #304

Merged
merged 15 commits into from
Sep 5, 2022
Merged

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Sep 5, 2022

This Pull Request does a few things:

  1. Configure Github releases as changelog. This configures the GitHub automatic release notes generator and a workflow to copy the release notes into the changelog when a release is made.
  2. Add a config for pre-commit (lightly modified from the one in astropy core).
  3. Update the config for isort
  4. run pyupgrade
  5. Remove setup.py and configure all the packaging in setup.cfg and pyproject.toml.

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #304 (d6e01fd) into main (9e4903f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d6e01fd differs from pull request most recent head c2bc9e5. Consider uploading reports for the commit c2bc9e5 to get more accurate results

@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
- Coverage   94.36%   94.34%   -0.02%     
==========================================
  Files          23       23              
  Lines         727      725       -2     
==========================================
- Hits          686      684       -2     
  Misses         41       41              
Impacted Files Coverage Δ
reproject/__init__.py 100.00% <100.00%> (ø)
reproject/adaptive/core.py 92.85% <100.00%> (-0.25%) ⬇️
reproject/adaptive/high_level.py 100.00% <100.00%> (ø)
reproject/healpix/utils.py 100.00% <100.00%> (ø)
reproject/interpolation/core.py 95.74% <100.00%> (ø)
reproject/mosaicking/wcs_helpers.py 100.00% <100.00%> (ø)
reproject/spherical_intersect/core.py 97.10% <100.00%> (ø)
reproject/utils.py 80.89% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Cadair Cadair changed the title GitHub changelog and pre-commit Update package infrastructure Sep 5, 2022
@Cadair Cadair force-pushed the github_changelog_etc branch 2 times, most recently from 26b23c5 to 3117951 Compare September 5, 2022 15:16
@Cadair
Copy link
Member Author

Cadair commented Sep 5, 2022

@astrofrog I think I have finally made this pass.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing all this! Just a small comment below but feel free to merge otherwise.

RELEASE_INSTRUCTIONS.md Outdated Show resolved Hide resolved
RELEASE_INSTRUCTIONS.md Outdated Show resolved Hide resolved
[ci skip]
@astrofrog astrofrog merged commit 89178da into astropy:main Sep 5, 2022
@Cadair Cadair deleted the github_changelog_etc branch September 6, 2022 09:39
@bsipocz
Copy link
Member

bsipocz commented Jan 30, 2023

FYI, this PR took away reproject.test() without mentioning it in the changelog, etc.

@astrofrog
Copy link
Member

@bsipocz Thanks for spotting this, don't think it was deliberate. How did you notice btw?

@bsipocz
Copy link
Member

bsipocz commented Jan 31, 2023

conda-forge packaging did run the user tests

@astrofrog
Copy link
Member

Ah I see! I will check how easy it is to add back and do a patch release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants