Fix TestReprojectAndCoAdd failure on i386 #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On i386, this test resulted in a failure because of relative differences ~2e-16. As floats are compared, minimal floating point differences my appear. This patch replaces the strict equal with an allclose test.
Codecov Report
@@ Coverage Diff @@
## main #386 +/- ##
=======================================
Coverage 93.53% 93.53%
=======================================
Files 25 25
Lines 882 882
=======================================
Hits 825 825
Misses 57 57 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On i386, this test resulted in a failure because of relative differences ~2e-16. As floats are compared, minimal floating point differences my appear. This PR replaces the strict equal with an allclose test.