Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read in IRAF FITS format (including multispec) #229

Open
andycasey opened this issue Jun 12, 2018 · 5 comments
Open

Read in IRAF FITS format (including multispec) #229

andycasey opened this issue Jun 12, 2018 · 5 comments
Labels

Comments

@andycasey
Copy link
Member

👋

I have some code (that @alexji and I maintain) that reads in IRAF FITS format of various types (chebyshev, legendre, polynomial, etc) that I'd be happy to update and create a pull request to bring it into the astropy ecosystem. It handles various dispersion mappings and multispec formats.

Would this be useful? If so, am I right in assuming that I should introduce it as an adapter in the specutils/wcs?

@nmearl
Copy link
Contributor

nmearl commented Jun 13, 2018

Hey @andycasey! We do have an implementation for reading IRAF FITS format in the previous specutils iteration, although it has not been brought over to the new specutils yet.

If you're interested, I would encourage you to see if merging the two implementations to perhaps improve upon what we both have is possible.

You would not need to create a new wcs adapter, as it's still a FITS file, and should follow the FITS wcs paradigm.

@crawfordsm
Copy link
Member

I think @simontorres was also working on this in #192

@simontorres
Copy link
Contributor

Yes, what I have done is mostly for reading non-linear wavelength solutions.

@eteq eteq added this to the v0.6.0 milestone Feb 28, 2019
SaOgaz pushed a commit that referenced this issue Mar 25, 2019
Pin conda version, add more conda output
@eteq eteq modified the milestones: v0.7, v0.8 Jan 4, 2020
@nmearl nmearl removed this from the v0.8 milestone May 5, 2020
@nmearl nmearl added the io label May 5, 2020
@travegre
Copy link

Hi all,

I was wondering if there is already a way (an implementation) to read multispec IRAF spectra with the new astropy/specutils versions?

@simontorres
Copy link
Contributor

I implemented some of the features some time ago but I'm not sure how it's working now or whether it survived all the recent changes in the package or maybe someone improved it.

Either way I must say it's tricky, at least that was my experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants