Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep model names after fitting #526

Merged
merged 2 commits into from
Oct 5, 2019
Merged

Keep model names after fitting #526

merged 2 commits into from
Oct 5, 2019

Conversation

xuanxu
Copy link
Member

@xuanxu xuanxu commented Oct 1, 2019

This PR makes fit_lines to preserve the names of the original model(s) after fitting.

Fixes #503

@nmearl
Copy link
Contributor

nmearl commented Oct 2, 2019

Thanks @xuanxu! Can you please include a test (or extend an existing one) that checks that the names within compound models are also maintained (as shown in #503)?

@nmearl nmearl added this to the v0.7 milestone Oct 2, 2019
@xuanxu
Copy link
Member Author

xuanxu commented Oct 2, 2019

@nmearl
Copy link
Contributor

nmearl commented Oct 2, 2019

@xuanxu Those tests only pertain to a single model, not compound models as in the example in the issue.

@xuanxu
Copy link
Member Author

xuanxu commented Oct 3, 2019

@nmearl done! Compound models are covered now.

Copy link
Contributor

@nmearl nmearl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @xuanxu!

@nmearl nmearl merged commit 605623b into astropy:master Oct 5, 2019
@xuanxu xuanxu deleted the model-names branch October 5, 2019 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model subcomponents names are not preserved after fitting
2 participants