Outlier array fix #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have corrected two bugs. The first is described in part of issue #94. There was an array dimension mismatch, that was caused by using masked arrays for some values, and only the un-masked elements for other values. The solution was to use masked arrays for both. Another bug was uncovered while fixing that one. In `get_lightcurve`, I had previously done away with the `_period` variable, and used `period` both as the function parameter and as an internal variable. It turns out that the distinction between `_period` and `period` actually had a subtle importance, as `period` never changed, causing a certain conditional to behave as expected. A new variable would need to be introduced in order to do away with `_period`, so I changed things back to their original form.
I have fixed the error described in issue #94, caused by a lack of outliers. The array index error is just a symptom, the real problem is that `matplotlib.pyplot.errorbar` will try to access element `0` in the `yerr` array, even if it is empty. This is a bug in matplotlib. The solution was to replace `yerr` with `None` whenever the value being passed had length zero.
This was referenced Dec 28, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all of the bugs described in #94.
It also fixes another bug discovered in the process:
periodis now only a parameter toget_lightcurve, and the internal variable_periodhas been brought back. The unchanged value of the inputperiodturned out to have a subtle importance in a conditional.