Feat/add comp rpt #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 1, 2018 10:28
|
line 445 and 446 of DBC is missing a 1+ or 0+ |
|
Why is all this CI stuff in here too? |
|
@zoakesAStuff - In order to use the new messages in astuff_sensor_msgs, I have to manually clone the astuff_sensor_msgs repo. I'm doing it with a shallow, sparse clone so it only gets the pacmod_msgs package. This will be removed in the future once the new astuff_sensor_msgs has been released to the official ROS repos. |
added 9 commits
October 3, 2018 13:13
|
@zoakesAStuff / @mlemm99 - The issues you brought up have been addressed and I added DBC validation to the CI stack. This will make sure that any future changes we make are, at the very least, automatically validated. Thanks. |
mlemm99
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.