Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image reader #61

Merged
merged 42 commits into from
Oct 20, 2022
Merged

Image reader #61

merged 42 commits into from
Oct 20, 2022

Conversation

bhaskar2443053
Copy link
Collaborator

This PR fixes #59

Description of changes

This a new x-ray image reader built for image classification task

Possible influences of this PR.

this reader needs forte 0.3.0.dev2 version to support image payload.

Test Conducted

Describe what test cases are included for the PR.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #61 (02ec91f) into master (b7fceb6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files          10       10           
  Lines         617      617           
=======================================
  Hits          534      534           
  Misses         83       83           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

fortex/health/readers/xray_image_reader.py Outdated Show resolved Hide resolved
fortex/health/readers/xray_image_reader.py Outdated Show resolved Hide resolved
tests/fortex/health/readers/xray_image_reader_test.py Outdated Show resolved Hide resolved
@Piyush13y
Copy link
Collaborator

Piyush13y commented Oct 18, 2022

@Piyush13y flake8 is throwing an error eps = importlib_metadata.entry_points().get(self.namespace, ()) AttributeError: 'EntryPoints' object has no attribute 'get'

with reference to

  1. https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean
  2. Breaking change in 7e5bae4 (importlib_metadata 5) python/importlib_metadata#409
    I tried to downgrade importlib_metadata and retest. But, It still shows the same error.

any suggestions?

@bhaskar2443053 If you look at the logs pertaining to your commits where you change the version in the setup file, it says we are still installing importlib-metadata-5.0 and not a deprecated version of it (<5.0.0). That's why you still see the same error when you downgraded the library.

Try adding importlib-metadata<5.0.0 in main.yml right before we install flake8 in the 'Install Dependencies' section, and see if that works.

@bhaskar2443053
Copy link
Collaborator Author

@Piyush13y flake8 is throwing an error eps = importlib_metadata.entry_points().get(self.namespace, ()) AttributeError: 'EntryPoints' object has no attribute 'get'
with reference to

  1. https://stackoverflow.com/questions/73929564/entrypoints-object-has-no-attribute-get-digital-ocean
  2. Breaking change in 7e5bae4 (importlib_metadata 5) python/importlib_metadata#409
    I tried to downgrade importlib_metadata and retest. But, It still shows the same error.

any suggestions?

@bhaskar2443053 If you look at the logs pertaining to your commits where you change the version in the setup file, it says we are still installing importlib-metadata-5.0 and not a deprecated version of it (<5.0.0). That's why you still see the same error when you downgraded the library.

Try adding importlib-metadata<5.0.0 in main.yml right before we install flake8 in the 'Install Dependencies' section, and see if that works.

Hi @Piyush13y I tried out your suggestion, but it gives a new error.

image

I also tried fast-deps, but this is also failing cl jobs.

@Piyush13y
Copy link
Collaborator

@bhaskar2443053 On downgrading the importlib-metadata library, flake8 was working fine. I have removed the redundant resolver from test installation too now. You can look at the issues in the pipeline checks now, should be resolvable. Let me know if you face any other issues.

@bhaskar2443053
Copy link
Collaborator Author

@bhaskar2443053 On downgrading the importlib-metadata library, flake8 was working fine. I have removed the redundant resolver from test installation too now. You can look at the issues in the pipeline checks now, should be resolvable. Let me know if you face any other issues.

great the importlib-metadata issue is solved. I also resolved the type ignore issue from reader. Now all cl has passed.
please review the PR again, and let me know if anything needs to be changed.

@Piyush13y Piyush13y merged commit 71b8d78 into asyml:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xray_image_reader
3 participants